Automatically use rich API on 1.30.0+ #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit detects the rustc version in the build script of proc-macro2 to determine whether the compiler supports the necessary backend APIs. This should hopefully allow the crate to compile on stable by default but have a better implementation on 1.30.0+ compilers.
alexcrichton
force-pushed
the
autodetect
branch
from
54f287d
to
ce0904d
Compare
|
Relevant: syn is soon going to emit real error messages when parsing fails. dtolnay/syn#47 (comment) |
|
Nice! |
|
This has broken Rocket's master. The |
This was referenced Sep 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit detects the rustc version in the build script of proc-macro2
to determine whether the compiler supports the necessary backend APIs.
This should hopefully allow the crate to compile on stable by default
but have a better implementation on 1.30.0+ compilers.