Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VersionReq incorrectly matches on prerelease versions #124

Closed
steveklabnik opened this issue Sep 10, 2017 · 1 comment
Closed

VersionReq incorrectly matches on prerelease versions #124

steveklabnik opened this issue Sep 10, 2017 · 1 comment

Comments

@steveklabnik
Copy link
Contributor

This should fail, but passes: https://play.rust-lang.org/?gist=fb9ab8b08c460ff4b0bb514f560cb079&version=stable

Originally found in rust-lang/cargo#4479

@dtolnay
Copy link
Owner

dtolnay commented May 25, 2021

I believe the current implementation is consistent with the behavior described for caret comparators in https://github.com/semver/semver/blob/efcff2c838c9945f79bfd21c1df0073271bcc29c/ranges.md (modulo the typo in semver/semver#584 (comment)). ^0.11.0-rc.2 is equivalent to >=0.11.0-rc.2, <0.12.0-0, and nothing there suggests to me that it shouldn't match 0.11.0.

@dtolnay dtolnay closed this as completed May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants