Add a few tests #239
Merged
Add a few tests #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I started looking into this a few months ago, but the issue is now fixed in 1.0.0! The version_req tests are based loosely on versions observed on crates.io. They previously failed to parse. The version tests do not fail on 0.12, but are added for completeness.
This parsed in 0.12 but is correctly rejected in 1.0.0.
According to #237 there are 4 cases: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit adds some tests related to #217, that regressed in 0.12. The tests now pass on 1.0.0.
The second commit adds a test for a new parse error. I haven't checked yet if we have any legacy versions on crates.io that violate this, but the error is to spec.