Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workaround for rustdoc displaying private fields #295

Merged
merged 1 commit into from
Dec 18, 2022

Conversation

dtolnay
Copy link
Owner

@dtolnay dtolnay commented Dec 18, 2022

rust-lang/rust#97933 has been fixed in rustdoc, so this PR undoes #286 and #281.

Correct rendering by old rustdoc (pre nightly-2022-04-14):

Screenshot from 2022-12-18 09-15-48

Rendering by buggy rustdoc:

Screenshot from 2022-12-18 09-15-40

Rendering with workaround:

Screenshot from 2022-12-18 09-17-01

Good enough rendering today with workaround removed:

Screenshot from 2022-12-18 09-17-25

@dtolnay dtolnay merged commit aa2c527 into master Dec 18, 2022
@dtolnay dtolnay deleted the rustdocworkaround branch December 18, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant