Add Item::attrs to get the attributes of an item if available
#1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jf2048
reviewed
Feb 15, 2023
| @@ -347,6 +347,32 @@ impl Item { | |||
| _ => unreachable!(), | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(feature = "parsing")] | |||
| pub fn attrs(&self) -> Option<&Vec<Attribute>> { | |||
There was a problem hiding this comment.
I have a similar implementation of this in a crate here: parse_attributes.rs#L336
I was able to have it simply return &[Attribute], and for Item::Verbatim it just returns &[]. Not sure if that is better or not.
|
Why isn't this PR being merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thanks for the crate!
When looking at
ItemI was surprised not to find APIs that ease its use, without having to pattern-match every time, like forrustc_hir::ItemKind. This PR add a convenience method to have an easy access to the attributes of an item.I don't know the policy about new APIs, so feel free to close if deemed out-of-scope. About the feature-flag to use and the documentation I can fix what's needed, when for
parsingas a first guess.As a side note
test_expr_sizeandtest_type_sizefail on arm64 (M1).