Normalize the effect of --verbose on '$N others' diagnostic
#277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--verboseflag from #270 was intended to control type name shortening (#269: "consider using `--verbose` to print the full type name to the console"). But it also changes the behavior of the kind of errors from #198. With--verbose, instead of "and $N others" rustc will print the full list of other trait impls, regardless of how many.This PR normalizes the effect of
--verboseon such diagnostics so that they better resemble what a real user would see, and to reduce churn in ui tests containing long impl lists.