Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use serde_derive via derive feature on serde #280

Conversation

waywardmonkeys
Copy link

No description provided.

Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #155 — the way serde is currently used is intentional.

Thanks anyway for the PR!

@dtolnay dtolnay closed this Jul 26, 2024
@waywardmonkeys
Copy link
Author

Interesting! I'm not seeing nearly that on my machine (an M3 Pro Max).

time reports about 10 to 10.2 seconds (total time) on a cargo build in this crate, but the difference comes in with the parallelization (as expected) as the utilization is 328% with them separate and 228% with this PR (actual wall time differs by about 1.5 seconds).

@dtolnay
Copy link
Owner

dtolnay commented Jul 26, 2024

Wall time is the relevant value.

On my machine (2990WX) it's 5.7 seconds before this PR and 9.1 seconds after this PR, which is a 60% regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants