Use swap instead of move in addForBlock

Use swap instead of move in DisconnectedBlockTransactions::addForBlock
in order to avoid potential problems for reusing the parents variable
after having moved it.

Signed-off-by: Andres Correa Casablanca <andres@thirdhash.com>

src/hash.cpp

@@ -165,7 +165,7 @@ uint64_t CSipHasher::Finalize() const
     return v0 ^ v1 ^ v2 ^ v3;
 }
 
-uint64_t SipHashUint256(uint64_t k0, uint64_t k1, const uint256& val)
+uint64_t SipHashUint256(const uint64_t k0, const uint64_t k1, const uint256& val)
 {
     /* Specialized implementation for efficiency */
     uint64_t d = val.GetUint64(0);

src/txmempool.cpp

@@ -1126,10 +1126,9 @@ void DisconnectedBlockTransactions::addForBlock(
         // In order to make sure we keep things in topological order, we check
         // if we already know of the parent of the current transaction. If so,
         // we remove them from the set and then add them back.
-        while (parents.size() > 0) {
-            std::unordered_set<uint256, SaltedTxidHasher> worklist(
-                std::move(parents)
-            );
+        while (!parents.empty()) {
+            std::unordered_set<uint256, SaltedTxidHasher> worklist;
+            parents.swap(worklist);
 
             for (const uint256 &txid : worklist) {
                 // If we do not have that txid in the set, nothing needs to be

src/txmempool.h

@@ -354,7 +354,7 @@ class SaltedTxidHasher
 {
 private:
     /** Salt */
-    const uint64_t k0, k1;
+    uint64_t k0, k1;
 
 public:
     SaltedTxidHasher();