move proposer* from esperanza/ to proposer/ #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scravy
force-pushed
the
move-proposer-logic
branch
15 times, most recently
from
2f2fd6a to
09385b4
Compare
scravy
force-pushed
the
move-proposer-logic
branch
from
09385b4 to
aa3ac21
Compare
scravy
changed the title
scravy
requested review from
AM5800,
cornelius,
frolosofsky,
Gnappuraz,
kostyantyn,
Nizametdinov,
Ruteri and
thothd
scravy
added
the
refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #153 I introduced a new component which is required for proposing and created the new namespace
proposerin theproposer/directory. This pull moves other already existing parts of the proposer into that directory.This is the result of a previous discussion in which we decided that we should not cramp everything into the
esperanza/directory and namespace. We already split the different log categories in an earlier pull (#151).