Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing bench/checkblock.cpp benchmark test (#722) #788

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

dsaveliev
Copy link
Member

Fixes #722.

The test bench/checkblock.cpp is failing due to outdated block fixture.
Here are a few changes that have affected the block structure:

In order to fix it, I generated a new, synthetic block fixture.

Signed-off-by: Dmitry Saveliev dima@thirdhash.com

@cmihai
Copy link
Member

cmihai commented Mar 14, 2019

Thanks for the fix. However, we'll need to open a new issue anyway, to replace the synthetic block with a real one -- a small block doesn't really stress the Unit-e daemon, which is the purpose of the benchmark.

Why not create a block with 1500 transactions for this right now, just like the original block 413567?

Signed-off-by: Dmitry Saveliev <dima@thirdhash.com>
@dsaveliev
Copy link
Member Author

@cmihai good point, I've increased block size up to 1500 transactions

Copy link
Member

@cmihai cmihai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK a5ff041

@thothd thothd added the performance Affecting the performance of the software label Mar 14, 2019
@dsaveliev dsaveliev added this to the 0.1 milestone Mar 14, 2019
@dsaveliev dsaveliev merged commit 4232fb5 into dtr-org:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Affecting the performance of the software
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bench is broken
3 participants