making CI run on main + b* branches #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Papior <nicpa@dtu.dk>
|
Nice update. Should pass all CI once the big 2024.2 PR is merged. |
The possibility of using numpy>=2 will be enabled by a later PR. Signed-off-by: Nick Papior <nicpa@dtu.dk>
|
yeah, this is a bit needed, so I will fix main to be runnable for numpy<2, then your PR should be the new main, and we will branch off for |
this is because pip is explicit in versions 3.12 == 3.12.0, not any 3.12. <3.13 is simpler Signed-off-by: Nick Papior <nicpa@dtu.dk>
Signed-off-by: Nick Papior <nicpa@dtu.dk>
Signed-off-by: Nick Papior <nicpa@dtu.dk>
Signed-off-by: Nick Papior <nicpa@dtu.dk>
Signed-off-by: Nick Papior <nicpa@dtu.dk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.