Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Sublime Text 3 support. #12

Merged
merged 1 commit into from
Sep 24, 2013
Merged

Added Sublime Text 3 support. #12

merged 1 commit into from
Sep 24, 2013

Conversation

kgantsov
Copy link
Contributor

No description provided.

@Kostanos
Copy link

@kgantsov I see this repo is not supported any more. I'm using your fork to install plugin on my ST3

I got this error after installing plugin:

Traceback (most recent call last):
  File "/opt/sublime_text/sublime_plugin.py", line 71, in reload_plugin
    m = imp.reload(m)
  File "X/imp.py", line 252, in reload
  File "/opt/sublime_text/sublime_plugin.py", line 671, in load_module
    exec(compile(source, source_path, 'exec'), mod.__dict__)
  File "FormatSQL in /home/kostya/.config/sublime-text-3/Installed Packages/SublimeFormatSQL.sublime-package", line 9
    view = self.view
                   ^
TabError: inconsistent use of tabs and spaces in indentation
found 4 files for base name Main.sublime-menu
theme loaded

The same error I got by installing from original repo.
Could you please fix it, so I will not need to create new fork from your's one :)

Thanks.
Kostya

@kgantsov
Copy link
Contributor Author

Oh, I see this error too. I'm just removed ~/Library/Application Support/Sublime Text 3/Installed Packages/Format SQL.sublime-package and error was gone and plugin working right.

du-song added a commit that referenced this pull request Sep 24, 2013
Added Sublime Text 3 support from @kgantsov
@du-song du-song merged commit 88771e4 into du-song:master Sep 24, 2013
@Kostanos
Copy link

I don't have FormatSQL package. Only SublimeFormatSQL package from your fork. Any other idea?
These are my packages (just upgraded to ST3 from ST2)

Package Control
Pretty JSON
SublimeFormatSQL
SublimePHPIntel # This one is disabled
SyncedSideBar  # This one is disabled

Thank you for the help!

@Kostanos
Copy link

Wow, just restarted the ST3 and the error has disappeared.
Thank you man!

@Kostanos
Copy link

@freewizard I see you are online, maybe it is better to open the new branch for ST3? I sow it on other plugins, this way you could maintain the support for ST2 for some period of time, until ST3 will not be stable.

Best and thank you for plugin,
K.

@kgantsov
Copy link
Contributor Author

This plugin must work for ST2 and ST3. When I added ST3 support I'm checked plugin for ST2 and it's worked for me.

@Kostanos
Copy link

Perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants