Ftr: change timeQ from limit chan to ultimate chan #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lvnszn
changed the title
justxuewei
approved these changes
Nov 16, 2021
AlexStocks
reviewed
Nov 16, 2021
LaurenceLiZhixin
approved these changes
Nov 17, 2021
|
@Lvnszn Please run go fmt. |
Lvnszn
force-pushed
the
feature/unbound_timer_channel
branch
from
8b6841e
to
e46db36
Compare
address |
AlexStocks
reviewed
Nov 17, 2021
AlexStocks
reviewed
Nov 17, 2021
AlexStocks
reviewed
Nov 17, 2021
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
==========================================
+ Coverage 73.27% 73.31% +0.04%
==========================================
Files 45 45
Lines 4550 4542 -8
==========================================
- Hits 3334 3330 -4
+ Misses 1013 1008 -5
- Partials 203 204 +1
Continue to review full report at Codecov.
|
AlexStocks
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
change timeQ from limit chan to ultimate chan
Which issue(s) this PR fixes:
Fixes
Special notes for your reviewer:
Does this PR introduce a user-facing change?: