Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable interface name binding on some platforms #331

Closed
wants to merge 3 commits into from
Closed

Disable interface name binding on some platforms #331

wants to merge 3 commits into from

Conversation

ducaale
Copy link
Owner

@ducaale ducaale commented Oct 21, 2023

Resolves #330

@blyxxyz
Copy link
Collaborator

blyxxyz commented Oct 21, 2023

I was about to make a PR with a feature-based solution: blyxxyz@a159996

The benefit is that when network-interface gets additional platform support we don't need to change anything on our end. The downside is that it won't build by default on unsupported platforms, you do need to use --no-default-features.

@ducaale
Copy link
Owner Author

ducaale commented Oct 21, 2023

Sounds good. I'll close this PR in favour of your WIP solution👍

@ducaale ducaale closed this Oct 21, 2023
@ducaale ducaale deleted the disable-interface-name-conditional branch October 21, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Latest release fails to build on NetBSD
2 participants
@ducaale @blyxxyz