Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendoring broken #190

Closed
krlmlr opened this issue Jun 29, 2024 · 3 comments
Closed

Vendoring broken #190

krlmlr opened this issue Jun 29, 2024 · 3 comments
Labels
bug an unexpected problem or unintended behavior

Comments

@krlmlr
Copy link
Collaborator

krlmlr commented Jun 29, 2024

With duckdb/duckdb#12636.

https://github.com/duckdb/duckdb-r/actions/runs/9722578776/job/26836690380#step:8:683

statement.cpp: In function ‘SEXPREC* rapi_execute(duckdb::stmt_eptr_t, bool, bool)’:
statement.cpp:345:39: error: ‘IsFinishedOrBlocked’ is not a member of ‘duckdb::PendingQueryResult’
  345 |         } while (!PendingQueryResult::IsFinishedOrBlocked(execution_result));
      |                                       ^~~~~~~~~~~~~~~~~~~
@krlmlr krlmlr added the bug an unexpected problem or unintended behavior label Jun 29, 2024
@krlmlr
Copy link
Collaborator Author

krlmlr commented Jul 4, 2024

@Tishj: PendingQueryResult::IsFinishedOrBlocked() is gone after duckdb/duckdb#12636, is it safe to replace with PendingQueryResult::IsFinished() ?

In #90, I introduced PendingQueryResult::IsFinishedOrBlocked() that seemed necessary back then, cherry-picking a commit by @Tmonster: #90 (comment) .

Thanks!

@Tishj
Copy link

Tishj commented Jul 4, 2024

@krlmlr Yes, that change was introduced by duckdb/duckdb#12636
You should now use PendingQueryResult::IsResultReady no matter if the result collector is materialized or streaming

I should have mentioned that in the PR description

@krlmlr
Copy link
Collaborator Author

krlmlr commented Aug 16, 2024

Fixed now, thanks!

@krlmlr krlmlr closed this as completed Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants