feat: Update core to duckdb v0.10.0 #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krlmlr
changed the title
This was referenced Feb 27, 2024
Closed
Merge pull request duckdb/duckdb#10650 from hannes/noprintf Merge pull request duckdb/duckdb#10658 from hannes/csvpathlength Merge pull request duckdb/duckdb#10245 from Tishj/parallel_streaming_query_result
Merge pull request duckdb/duckdb#10650 from hannes/noprintf Merge pull request duckdb/duckdb#10658 from hannes/csvpathlength Merge pull request duckdb/duckdb#10612 from samansmink/delay-secret-storage-directory-initialization Merge pull request duckdb/duckdb#10611 from Mytherin/currenttimealias Merge pull request duckdb/duckdb#10616 from hannes/jdbctestchanged Merge pull request duckdb/duckdb#10607 from carlopi/secret_folder Merge pull request duckdb/duckdb#10603 from carlopi/extensions_patches Merge pull request duckdb/duckdb#10606 from Mytherin/duckdbmemoryinit Merge pull request duckdb/duckdb#10604 from Mytherin/aggregatelimit Merge pull request duckdb/duckdb#10592 from carlopi/error_message_lock Merge pull request duckdb/duckdb#10600 from samansmink/secret-manager-fixes-2 Merge pull request duckdb/duckdb#10589 from pdet/csv_result_buffer_hold Merge pull request duckdb/duckdb#10605 from Tishj/julia_remove_dataframe Merge pull request duckdb/duckdb#10596 from pdet/null_padding_projection_finalize Merge pull request duckdb/duckdb#10590 from Tmonster/investigate-cardinality-estimates-parquet Merge pull request duckdb/duckdb#10598 from szarnyasg/add-support-options Merge pull request duckdb/duckdb#10579 from Tishj/unittest_require_flag Merge pull request duckdb/duckdb#10202 from Tishj/sorted_aggregate_function_small_vector_size Merge pull request duckdb/duckdb#10553 from Tmonster/fuzzer_column_binding_issues Merge pull request duckdb/duckdb#10513 from Maxxen/array-tupledata-fix Merge pull request duckdb/duckdb#10584 from Mause/datetime-delta Merge pull request duckdb/duckdb#10582 from carlopi/fix_extension_distribution Merge pull request duckdb/duckdb#10580 from Maxxen/bump-spatial Merge pull request duckdb/duckdb#10532 from Tishj/deduplicate_columns Merge pull request duckdb/duckdb#10573 from carlopi/fixthreads Merge pull request duckdb/duckdb#10572 from carlopi/noexit Merge pull request duckdb/duckdb#10571 from Tishj/time_cast_heap_overflow Merge pull request duckdb/duckdb#10569 from Tishj/fix_export_of_types Merge pull request duckdb/duckdb#10568 from Tishj/pytest_does_not_throw_httpexception Merge pull request duckdb/duckdb#10567 from Tishj/require_no_alternative_verify Merge pull request duckdb/duckdb#10565 from Tishj/arrow_support_time_tz Merge pull request duckdb/duckdb#10563 from Tishj/python_exception_bug Merge pull request duckdb/duckdb#10559 from Mytherin/issue10528 Merge pull request duckdb/duckdb#10548 from ywelsch/yw/duckdb-only-server-threads Merge pull request duckdb/duckdb#10564 from carlopi/fix01init Merge pull request duckdb/duckdb#10560 from carlopi/rowsorts Merge pull request duckdb/duckdb#10558 from pdet/bug_9952 Merge pull request duckdb/duckdb#10555 from carlopi/refactorcommit Merge pull request duckdb/duckdb#10557 from pdet/reset-quoted-proj Merge pull request duckdb/duckdb#10504 from Mytherin/queryid Merge pull request duckdb/duckdb#10487 from felipecrv/upper_bound Merge pull request duckdb/duckdb#10552 from pdet/fix_glob_partition_test Merge pull request duckdb/duckdb#10551 from pdet/segfault-fix Merge pull request duckdb/duckdb#10554 from Mytherin/benchmarkerrors Merge pull request duckdb/duckdb#10485 from Tmonster/list_zip_no_args Merge pull request duckdb/duckdb#10536 from motherduckdb/flo/add-order-to-tests Merge pull request duckdb/duckdb#10549 from lnkuiper/radix_ht_reservation Merge pull request duckdb/duckdb#10525 from Tishj/parallel_checkpoint_error_race Merge pull request duckdb/duckdb#10541 from Mytherin/arrayextractunnamedstruct Merge pull request duckdb/duckdb#10538 from Maxxen/copy-file-path-fix Merge pull request duckdb/duckdb#10544 from hawkfish/tz2024a Merge pull request duckdb/duckdb#10542 from carlopi/fixes Merge pull request duckdb/duckdb#10408 from Mause/feature/jdbc-set-date Merge pull request duckdb/duckdb#10531 from ywelsch/yw/client-context-in-attach Merge pull request duckdb/duckdb#10537 from Mytherin/structcastoutoforder Merge pull request duckdb/duckdb#10534 from Mytherin/applypatchesfix Merge pull request duckdb/duckdb#10488 from Tishj/python_editable_build Merge pull request duckdb/duckdb#10527 from Mytherin/linenoiseenterbehavior Merge pull request duckdb/duckdb#10530 from pdet/bug_null_csv_ignore Merge pull request duckdb/duckdb#10533 from Tishj/python_fixes_2024_2_8 Merge pull request duckdb/duckdb#10526 from lnkuiper/null_to_json_cast Merge pull request duckdb/duckdb#10529 from philippmd/philippmd/errno-ioexception Merge pull request duckdb/duckdb#10503 from lnkuiper/temporary_memory_manager_tweaks Merge pull request duckdb/duckdb#10500 from Mytherin/issue910 Merge pull request duckdb/duckdb#10357 from kryonix/main Merge pull request duckdb/duckdb#10521 from Mause/patch-4 Merge pull request duckdb/duckdb#10518 from motherduckdb/secrets-changes Merge pull request duckdb/duckdb#10514 from Mytherin/exceptionstacktrace Merge pull request duckdb/duckdb#10512 from Tishj/executor_race_condition Merge pull request duckdb/duckdb#10510 from Tishj/gcc_is_stupid Merge pull request duckdb/duckdb#10509 from pdet/csv_big_data Merge pull request duckdb/duckdb#10505 from Mytherin/issue10363 Merge pull request duckdb/duckdb#10507 from carlopi/bundle-libraries Merge pull request duckdb/duckdb#10459 from Maxxen/copy-tmp-ext Merge pull request duckdb/duckdb#10483 from Maxxen/array-bugfix Merge pull request duckdb/duckdb#10502 from Mytherin/autocompletefix Merge pull request duckdb/duckdb#10499 from Mytherin/issue1164 Merge pull request duckdb/duckdb#10498 from Mytherin/disablecompletionrendering Merge pull request duckdb/duckdb#10496 from Mytherin/memorymanagement Merge pull request duckdb/duckdb#10492 from SChakravorti21/fix-empty-normalized-version Merge pull request duckdb/duckdb#10484 from Flogex/extension-build-script Merge pull request duckdb/duckdb#10493 from Mytherin/altcommands Merge pull request duckdb/duckdb#10475 from rdavis120/main Merge pull request duckdb/duckdb#10480 from Mytherin/autocompletedisplay Merge pull request duckdb/duckdb#10473 from pdet/bug_10283 Merge pull request duckdb/duckdb#10479 from hannes/windowsarm Merge pull request duckdb/duckdb#10471 from Maxxen/custom-index-fork Merge pull request duckdb/duckdb#10474 from Mytherin/gzipfs Merge pull request duckdb/duckdb#10472 from pdet/bug_10273 Merge pull request duckdb/duckdb#10470 from Mytherin/clearcontinuationmarkers Merge pull request duckdb/duckdb#10467 from carlopi/fixes Merge pull request duckdb/duckdb#10465 from pdet/type_misdetection Merge pull request duckdb/duckdb#10462 from pdet/double_quoted_header Merge pull request duckdb/duckdb#10461 from Mytherin/linenoisecleanup Merge pull request duckdb/duckdb#10464 from Tishj/improve_julia_dev_readme
krlmlr
commented
Jun 29, 2024
| @@ -337,7 +337,7 @@ bool FetchArrowChunk(ChunkScanState &scan_state, ClientProperties options, Appen | |||
| do { | |||
| execution_result = pending_query->ExecuteTask(); | |||
| R_CheckUserInterrupt(); | |||
| } while (!PendingQueryResult::IsFinished(execution_result)); | |||
| } while (!PendingQueryResult::IsFinishedOrBlocked(execution_result)); | |||
There was a problem hiding this comment.
@Tmonster: I cherry-picked this for #90, this seemed necessary due to some change in the core. This now breaks again, #190, after duckdb/duckdb#12636. Is this safe to revert, what do you think?
CC @Tishj.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With all tests passing.