Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid regex in .Rbuildignore #108

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Conversation

Tmonster
Copy link
Contributor

An invalid regex in the .RbuildIgnore is causing many CI failures. A * regex character cannot match the ^ character 0 or more times.
I've changed it to .* but I'm not sure if the original intention is to match everything with the suffix _files

@Tmonster Tmonster requested review from krlmlr and hannes March 13, 2024 12:44
@hannes hannes removed their request for review March 13, 2024 12:57
@Mytherin Mytherin merged commit 32407f9 into duckdb:main Mar 13, 2024
13 checks passed
@Mytherin
Copy link
Contributor

Thanks!

Copy link
Collaborator

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants