-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Driver registry #124
Driver registry #124
Conversation
1163852
to
ea52aac
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
==========================================
+ Coverage 85.87% 86.28% +0.41%
==========================================
Files 107 107
Lines 3639 3712 +73
==========================================
+ Hits 3125 3203 +78
+ Misses 514 509 -5 ☔ View full report in Codecov by Sentry. |
6bcb2e8
to
27c6c4c
Compare
27c6c4c
to
472f1ef
Compare
a382541
to
7544711
Compare
7544711
to
81bdeb6
Compare
Merging now to get binaries from r-universe. Highly appreciate your review! |
This PR does many things:
std::unordered_map<>
in C++; before commit "Store config with driver object"duckdb()
indbConnect()
, and vice versa (before commit "path_normalize")With this change, each database file is opened only once, by the call to
duckdb()
. The database file is closed when the last connection is closed correctly withdbDisconnect()
, or when it is garbage-collected (with a warning). The connection still must be closed withdbDisconnect()
, but theshutdown
argument that was necessary before is now meaningless.Check consistency of config and readonly objects