feat: round() duckdb translation uses ROUND_EVEN() instead of ROUND()
#157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lschneiderbauer
force-pushed
the
round_even
branch
from
bae9924 to
d752be4
Compare
krlmlr
reviewed
May 22, 2024
| @@ -160,7 +160,7 @@ sql_translation.duckdb_connection <- function(con) { | |||
| regexpr = function(p, x) { | |||
| build_sql("(CASE WHEN REGEXP_MATCHES(", x, ", ", p, ") THEN (LENGTH(LIST_EXTRACT(STRING_SPLIT_REGEX(", x, ", ", p, "), 0))+1) ELSE -1 END)") | |||
| }, | |||
| round = function(x, digits) sql_expr(ROUND(!!x, CAST(ROUND((!!digits), 0L) %AS% INTEGER))), | |||
| round = function(x, digits = 0) sql_expr(ROUND_EVEN(!!x, CAST(ROUND((!!digits), 0L) %AS% INTEGER))), | |||
There was a problem hiding this comment.
Do we want a test for calling round() with a single argument?
krlmlr
changed the title
round() duckdb translation: use round_even() instead of round()round() duckdb translation uses ROUND_EVEN() instead of ROUND()
…ead of `round()` to be consistent with the way rounding works in R
|
Thanks! Let's add that missing test later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
round()toround(x, digits = 0)to be consistent with the R default value.Fixes #146