feat: n_distinct() supports na.rm = TRUE with a single vector argument again
#216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lschneiderbauer
force-pushed
the
n_distinct_na-rm-true
branch
from
532523e
to
e66fcfe
Compare
krlmlr
approved these changes
Sep 14, 2024
|
|
||
| # https://duckdb.org/docs/sql/data_types/struct.html#creating-structs-with-the-row-function | ||
| str_struct <- paste0("row(", paste0(list(...), collapse = ", "), ")") | ||
| return(sql(paste0("COUNT(DISTINCT ", cols[[1]], ")"))) |
There was a problem hiding this comment.
It seems totally fine to omit the return() here and below. Not a breaker.
| # Why not use ROW() as well? Because duckdb's FILTER clause does not support | ||
| # a windowing context as of now: https://duckdb.org/docs/sql/query_syntax/filter.html | ||
| if (length(cols) > 1) { | ||
| stop("n_distinct(): Only one vector argument is currently supported when `na.rm = TRUE`.", call. = FALSE) |
There was a problem hiding this comment.
I wouldn't understand "vector argument" when seeing this error, but it makes sense in the context of this PR and it's also easy to find.
krlmlr
changed the title
n_distinct(): restore na.rm = TRUE capability with single vector argumentn_distinct() supports na.rm = TRUE with a single vector argument again
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #204 .