-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Align the argument order of dbWriteTable()
with the DBI specs
#49
Conversation
@krlmlr Is there any reason why this would not be merged? Is there anything I can do? |
dbWriteTable()
dbWriteTable()
dbWriteTable()
with the DBI specs
Thanks. Running revdepchecks now. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
=======================================
Coverage 85.89% 85.89%
=======================================
Files 106 106
Lines 3602 3602
=======================================
Hits 3094 3094
Misses 508 508 ☔ View full report in Codecov by Sentry. |
Uploaded results, one package has new failures. Could you please take a look? |
I have looked and found that the results were also different in duckdb installed from R-universe, so I think this is due to a change in the order of the records returned by duckdb and this PR is irrelevant. |
I've send a PR for fix the test cases darwin-eu-dev/PatientProfiles#456. |
Thanks, also for double-checking! |
Fix #43