-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Change directory location for extensions and secrets for v.0.10.0 release #73
chore: Change directory location for extensions and secrets for v.0.10.0 release #73
Conversation
Smoke test is failing because source code for v0.10.0 has not yet been merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Do we currently have a way to fetch the version of the bundled duckdb sources?
Yes: con <- DBI::dbConnect(duckdb::duckdb(), ":memory:")
DBI::dbGetQuery(con, "PRAGMA version")
#> library_version source_id
#> 1 v0.9.3-dev3731 d4c774b1f1 Created on 2024-02-24 with reprex v2.1.0 Can you please help me understand the nature of the config vs. the pragmas. Is the config private to the database connection, or shared across connections initiated with the same |
We should embed the version of the bundled code in the R code too so that it is available without asking duckdb. |
The config is private to the database connection. A config then stores a |
@krlmlr you might need to run the tests again. I'm trying to push empty commits to force the CI to run again, but GitHub doesn't seem to be picking it up |
a3c7343
to
03c5fbe
Compare
d814e75
to
6ef5eae
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
=======================================
Coverage 85.93% 85.94%
=======================================
Files 106 106
Lines 3619 3621 +2
=======================================
+ Hits 3110 3112 +2
Misses 509 509 ☔ View full report in Codecov by Sentry. |
Thanks! |
No description provided.