Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Change directory location for extensions and secrets for v.0.10.0 release #73

Merged
merged 5 commits into from
Mar 3, 2024

Conversation

Tmonster
Copy link
Contributor

No description provided.

@Tmonster
Copy link
Contributor Author

Smoke test is failing because source code for v0.10.0 has not yet been merged

Copy link
Collaborator

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Do we currently have a way to fetch the version of the bundled duckdb sources?

@krlmlr
Copy link
Collaborator

krlmlr commented Feb 24, 2024

Yes:

con <- DBI::dbConnect(duckdb::duckdb(), ":memory:")
DBI::dbGetQuery(con, "PRAGMA version")
#>   library_version  source_id
#> 1  v0.9.3-dev3731 d4c774b1f1

Created on 2024-02-24 with reprex v2.1.0

Can you please help me understand the nature of the config vs. the pragmas. Is the config private to the database connection, or shared across connections initiated with the same duckdb() driver?

@krlmlr
Copy link
Collaborator

krlmlr commented Feb 24, 2024

We should embed the version of the bundled code in the R code too so that it is available without asking duckdb.

@Tmonster
Copy link
Contributor Author

Can you please help me understand the nature of the config vs. the pragmas. Is the config private to the database connection, or shared across connections initiated with the same duckdb() driver?

The config is private to the database connection. A config then stores a DBConfigOptions which then stores certain settings set by pragma function calls. Each config also stores information about extensions. If multiple read connections are created, each one could have different DBConfigOptions or extensions, which is why each config is private to the database.

@krlmlr krlmlr added this to the 0.10.0 milestone Feb 27, 2024
@Tmonster
Copy link
Contributor Author

Tmonster commented Mar 1, 2024

@krlmlr you might need to run the tests again. I'm trying to push empty commits to force the CI to run again, but GitHub doesn't seem to be picking it up

@Tmonster Tmonster force-pushed the fix_location_of_extensions_and_secrets branch from a3c7343 to 03c5fbe Compare March 1, 2024 15:38
@krlmlr krlmlr force-pushed the fix_location_of_extensions_and_secrets branch from d814e75 to 6ef5eae Compare March 3, 2024 11:26
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.94%. Comparing base (871244d) to head (71a02e6).

❗ Current head 71a02e6 differs from pull request most recent head d24fe5f. Consider uploading reports for the commit d24fe5f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage   85.93%   85.94%           
=======================================
  Files         106      106           
  Lines        3619     3621    +2     
=======================================
+ Hits         3110     3112    +2     
  Misses        509      509           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krlmlr krlmlr changed the title Change directory location for extensions and secrets for v.0.10.0 release chore: Change directory location for extensions and secrets for v.0.10.0 release Mar 3, 2024
@krlmlr krlmlr merged commit 71ff5b1 into duckdb:main Mar 3, 2024
18 checks passed
@krlmlr
Copy link
Collaborator

krlmlr commented Mar 3, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants