Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DBI::dbQuoteIdentifier() correctly quotes identifiers that start with a digit #92

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

krlmlr
Copy link
Collaborator

@krlmlr krlmlr commented Feb 27, 2024

Closes #67.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.92%. Comparing base (4a82721) to head (eaf94fd).
Report is 6 commits behind head on main.

❗ Current head eaf94fd differs from pull request most recent head 57b615f. Consider uploading reports for the commit 57b615f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage   85.92%   85.92%           
=======================================
  Files         106      106           
  Lines        3609     3609           
=======================================
  Hits         3101     3101           
  Misses        508      508           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krlmlr krlmlr merged commit 4a975f7 into main Feb 27, 2024
13 checks passed
@krlmlr krlmlr deleted the b-67-quote-digit branch February 27, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not correctly escaping column names in sql for duckdb connection
2 participants