Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for azure credential chain #16

Merged
merged 8 commits into from
Oct 13, 2023
Merged

Add support for azure credential chain #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ebe7016
add support for azure credential chain
samansmink Oct 12, 2023
e4fb5a3
make endpoint configurable
samansmink Oct 12, 2023
cf2991b
fix broken test
samansmink Oct 12, 2023
cf26572
Merge branch 'main' into add-credential-chain
samansmink Oct 12, 2023
a2728ed
pin vcpkg to latest version
samansmink Oct 12, 2023
0ccfb82
update vcpkg for other workflows
samansmink Oct 12, 2023
830f0a6
fix pr comments
samansmink Oct 13, 2023
fb68a82
format
samansmink Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/Linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ jobs:
- name: Setup vcpkg
uses: lukka/run-vcpkg@v11
with:
vcpkgGitCommitId: 501db0f17ef6df184fcdbfbe0f87cde2313b6ab1
vcpkgGitCommitId: 9edb1b8e590cc086563301d735cae4b6e732d2d2

# Build extension
- name: Build extension
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/MacOS.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
- name: Setup vcpkg
uses: lukka/run-vcpkg@v11
with:
vcpkgGitCommitId: 501db0f17ef6df184fcdbfbe0f87cde2313b6ab1
vcpkgGitCommitId: 9edb1b8e590cc086563301d735cae4b6e732d2d2

- name: Build extension
shell: bash
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/MainDistributionPipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ jobs:
with:
duckdb_version: v0.9.1
extension_name: azure
vcpkg_commit: 9edb1b8e590cc086563301d735cae4b6e732d2d2 # TODO: remove pinned vcpkg commit when updating duckdb version

duckdb-stable-deploy:
name: Deploy extension binaries
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
- name: Setup vcpkg
uses: lukka/run-vcpkg@v11
with:
vcpkgGitCommitId: 501db0f17ef6df184fcdbfbe0f87cde2313b6ab1
vcpkgGitCommitId: 9edb1b8e590cc086563301d735cae4b6e732d2d2
samansmink marked this conversation as resolved.
Show resolved Hide resolved

- uses: actions/setup-python@v2
with:
Expand Down
13 changes: 9 additions & 4 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,17 @@
find_package(azure-storage-blobs-cpp CONFIG REQUIRED)

# Static lib
target_link_libraries(${EXTENSION_NAME} Azure::azure-identity Azure::azure-storage-blobs)
target_include_directories(${EXTENSION_NAME} PRIVATE Azure::azure-identity Azure::azure-storage-blobs)
target_link_libraries(${EXTENSION_NAME} Azure::azure-identity
Azure::azure-storage-blobs)
target_include_directories(${EXTENSION_NAME} PRIVATE Azure::azure-identity
Azure::azure-storage-blobs)

# Loadable binary
target_link_libraries(${TARGET_NAME}_loadable_extension Azure::azure-identity Azure::azure-storage-blobs)
target_include_directories(${TARGET_NAME}_loadable_extension PRIVATE Azure::azure-identity Azure::azure-storage-blobs)
target_link_libraries(${TARGET_NAME}_loadable_extension Azure::azure-identity
Azure::azure-storage-blobs)
target_include_directories(
${TARGET_NAME}_loadable_extension PRIVATE Azure::azure-identity
Azure::azure-storage-blobs)

install(
TARGETS ${EXTENSION_NAME}
Expand Down
Loading
Loading