Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support az:// scheme #21

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Support az:// scheme #21

merged 3 commits into from
Nov 7, 2023

Conversation

chrisiou
Copy link
Contributor

@chrisiou chrisiou commented Nov 6, 2023 •
edited
Loading

This PR introduces the az:// scheme and provides additional testing.
Additionally, it includes a CMake message for when the azure-identity-cpp and azure-storage-blobs-cpp packages cannot be found.

@chrisiou chrisiou changed the title Support az:// prefix Support az:// scheme Nov 7, 2023
samansmink
samansmink approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@samansmink samansmink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @chrisiou! Thanks for the PR, looks great!

@samansmink samansmink merged commit e705776 into duckdb:main Nov 7, 2023
20 checks passed
@chrisiou chrisiou deleted the support-azure-prefixes branch November 7, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samansmink samansmink samansmink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisiou @samansmink