Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include http stats in the explain analyze statement #26

Merged
merged 3 commits into from
Dec 8, 2023

Conversation

chrisiou
Copy link
Contributor

@chrisiou chrisiou commented Dec 5, 2023

This PR includes HTTP info collected from Azure Storage in the explain analyze statement output.

changes:

  • utilizes theAzure::Core::Diagnostics::Logger to capture logs and uses a global instance of http_state to maintain stats
  • added an azure_http_stats setting option, which enables this feature (default value is false)
  • expanded the azure.test with additional statements

notes/limitations:

  • guarded global variables are used to allow sharing the stats across multiple files in parsing
  • the results may be inaccurate for more than one active duckdb connection
  • the extraction of received and sent bytes is not implemented. (I am not very familiar with Azure Storage, so) here are some links that may be useful for a future try:

Copy link
Collaborator

@samansmink samansmink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @chrisiou thanks for the PR, looks great! i added 2 small comments

src/azure_extension.cpp Outdated Show resolved Hide resolved
src/include/azure_extension.hpp Show resolved Hide resolved
@samansmink
Copy link
Collaborator

Thanks again @chrisiou!

@samansmink samansmink merged commit 6b1f93f into duckdb:main Dec 8, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants