-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/hierarchical namespace #49
Feature/hierarchical namespace #49
Conversation
I will wait for the PR#45 to update the tests |
5a9adfb
to
3995ba1
Compare
3995ba1
to
cdeb51c
Compare
Hi @samansmink, I would like some help for setting up the hierarchical namespace tests, if that all right for you. Regards, |
Note (to discuss):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @quentingodeau, amazing work, this looks great!
I've tried to set up the CI side of things but i'm running into some issues. Maybe we can have a chat? Its probably me misunderstanding the connection strings.
I've also added some comments.
Perhaps we can have a chat on discord? You can find me on the duckdb discord or just add directly: samansmink
Make tests work with DFS and BLOB to use the same storage account (must be created with the hierarchical namespace option enabled to run abfss tests)
Hi @samansmink, sorry for the delay! |
Hum the cloud testing didn't run. Are they trigger manually? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the changes, this looks great! Added some small comments
@quentingodeau they don't run on PRs for security purposes. They will run on main, and I will check them manually as part of review. |
Add support of DFS endpoint (#43)