-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add REST Catalog and generate some test data #27
Conversation
It looks like the CI is failing on main? https://github.com/duckdb/duckdb_iceberg/actions/runs/6800435295/job/18523077842?pr=27 |
@samansmink ah nice one, thanks! |
Hey @Fokko! I think CI is failing because docker compose is not available in the manylinux image. So could you strip both the linux_arm64 and the linux_amd64_gcc4 from the REST.yml? |
Hey @samansmink thanks for pinging me. Let me check right away! |
d9fae26
to
c8c0adb
Compare
785876f
to
182e079
Compare
@samansmink It should pass now. It was a bit of a hassle with the docker-in-docker problem, but let me know what you think! |
@Fokko Thanks a lot for all the work on this. Having a proper iceberg setup to test against is super useful! I've started CI for the PR After this gets merged I'll look into using this for more of the tests and implementing the REST Catalog against this |
Hey @samansmink Cool stuff The spec can be found here: https://github.com/apache/iceberg/blob/main/open-api/rest-catalog-open-api.yaml Personally, I like to check the Python objects here to see what the requests/responses are. I think it is easier to read than the yaml. Let me know if you need any help! |
LGTM, thanks again! |
Add REST Catalog and generate some test data
No description provided.