Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Rest catalog integration test. #100

Closed
liurenjie1024 opened this issue Nov 18, 2023 · 3 comments · Fixed by #109
Closed

test: Rest catalog integration test. #100

liurenjie1024 opened this issue Nov 18, 2023 · 3 comments · Fixed by #109
Assignees
@liurenjie1024

Comments

@liurenjie1024
Copy link
Contributor

We need to do integration test for rest catalog against rest catalog server. Tabular has an docker image for this.
@liurenjie1024 liurenjie1024 self-assigned this Nov 18, 2023
@liurenjie1024
Copy link
Contributor Author

I'm happy to take this, I have implemented similar things in icelake.

@Fokko
Copy link
Contributor

Fokko commented Nov 19, 2023

@liurenjie1024 Thanks for raising this. This made the testing on PyIceberg much easier. Also, I've created a similar PR for duckdb: duckdb/duckdb-iceberg#27 which might provide some inspiration.

@liurenjie1024
Copy link
Contributor Author

@liurenjie1024 Thanks for raising this. This made the testing on PyIceberg much easier. Also, I've created a similar PR for duckdb: duckdb/duckdb_iceberg#27 which might provide some inspiration.

Thanks! I will take a look when implementing this.

@liurenjie1024 liurenjie1024 mentioned this issue Nov 21, 2023
Merged
@liurenjie1024 liurenjie1024 mentioned this issue Nov 28, 2023
Merged
@Fokko Fokko closed this as completed in #109 Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liurenjie1024 liurenjie1024

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Add integration tests for rest catalog. liurenjie1024/iceberg-rust
2 participants
@Fokko @liurenjie1024