Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make bootstrap check names earlier #77

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

tshauck
Copy link
Contributor

@tshauck tshauck commented Jul 20, 2024

Right now if you enter a bad name initially, you get stuck in a bad state because some of the file updates happen before the name is checked. This PR reorgs the script so that it's generally organized more like a standard python script, but also moves the name validation before the rest of the script so it's less likely an extension creator gets into a bad state.

@samansmink
Copy link
Collaborator

Thanks for the PR, good idea! I've pushed a minor workaround to get the Linux CI running

@tshauck
Copy link
Contributor Author

tshauck commented Jul 22, 2024

Thanks!

@samansmink samansmink merged commit cb7641d into duckdb:main Jul 22, 2024
25 checks passed
@tshauck tshauck deleted the improve-bootstrap branch July 22, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants