Show on App Launch: General settings entry point #4946
Merged
+1,594
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @mikescamell and the rest of your teammates on |
This was referenced Aug 28, 2024
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/implementation
branch
from
1f3b960
to
5dbdb61
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/general-settings-entry-point
branch
from
caac36c
to
8a52cd9
Compare
anikiki
approved these changes
Sep 2, 2024
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/implementation
branch
from
5dbdb61
to
8e2a56f
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/general-settings-entry-point
branch
from
8a52cd9
to
164c074
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/implementation
branch
from
8e2a56f
to
67fbe46
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/general-settings-entry-point
branch
from
164c074
to
781ef4a
Compare
55 tasks
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/implementation
branch
from
67fbe46
to
b5bd938
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/general-settings-entry-point
branch
from
781ef4a
to
46c9f4f
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/implementation
branch
from
b5bd938
to
addd3a0
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/general-settings-entry-point
branch
from
46c9f4f
to
9a079f6
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/implementation
branch
from
addd3a0
to
55cc562
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/general-settings-entry-point
branch
from
9a079f6
to
bb0c0a8
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/implementation
branch
from
55cc562
to
18e7233
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/general-settings-entry-point
branch
from
bb0c0a8
to
fb3e506
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/implementation
branch
from
18e7233
to
098626f
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/general-settings-entry-point
branch
from
fb3e506
to
17bae85
Compare
12 tasks
we'll add the new screen in a new PR
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/implementation
branch
from
098626f
to
bbdbaa4
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/general-settings-entry-point
branch
from
17bae85
to
03f047d
Compare
Task/Issue URL: https://app.asana.com/0/1207908166761516/1208156273709081/f ### Description Adds the UI for the Show on App Launch settings screen and allows switching options. Nothing is stored and no validation. I moved RadioListItem to the `common-ui` module seeing as it’s now being used in multiple places. [Designs](https://www.figma.com/design/N2GbF5HEvopp5iwmAlMwyD/New-Tab-Page-Customization?node-id=1741-64495&t=SpS14wACEtPydb2z-4) ### Steps to test this PR - [x] Open Settings - [x] Open General section - [x] Click “Show on App Launch” - [x] Ensure each setting can be switched - [x] Ensure the TextInput for the “Specific Page” option is only visible when selected - [x] Ensure you cannot do multiple lines when entering a URL for “Specific Page" ### UI changes [Screen_recording_20240828_162354.webm](https://github.com/user-attachments/assets/7e45b454-2bd3-455b-af19-499ac19cabfa) --------- Co-authored-by: Marcos Holgado <marcosh@duckduckgo.com> Co-authored-by: Dax The Translator <daxmobile@duckduckgo.com>
mikescamell
merged commit 42c5105
into
feature/mike/show-on-app-launch/implementation
4 of 5 checks passed
mikescamell
deleted the
feature/mike/show-on-app-launch/general-settings-entry-point
branch
5 tasks
10 tasks
51 tasks
mikescamell
added a commit
that referenced
this pull request
Oct 21, 2024
Task/Issue URL: https://app.asana.com/0/1207908166761516/1208156273709078/f ### Description Adds the “Show on App Launch” entry point in the General settings screen. We will likely not use a `String` to determine the secondary text but this makes it easier for step by step implementation. [Designs](https://www.figma.com/design/N2GbF5HEvopp5iwmAlMwyD/New-Tab-Page-Customization?node-id=1741-64494&t=SpS14wACEtPydb2z-4) ### Steps to test this PR - [x] Open settings - [x] Click “General” - [x] Check “Show on App Launch” is bottom of the list ### UI changes | Before | After | | ------ | ----- | |  |  | --------- Co-authored-by: Marcos Holgado <marcosh@duckduckgo.com> Co-authored-by: Dax The Translator <daxmobile@duckduckgo.com> # Conflicts: # app/src/main/res/values-bg/strings.xml # app/src/main/res/values-cs/strings.xml # app/src/main/res/values-da/strings.xml # app/src/main/res/values-de/strings.xml # app/src/main/res/values-el/strings.xml # app/src/main/res/values-es/strings.xml # app/src/main/res/values-et/strings.xml # app/src/main/res/values-fi/strings.xml # app/src/main/res/values-fr/strings.xml # app/src/main/res/values-hr/strings.xml # app/src/main/res/values-hu/strings.xml # app/src/main/res/values-it/strings.xml # app/src/main/res/values-lt/strings.xml # app/src/main/res/values-lv/strings.xml # app/src/main/res/values-nb/strings.xml # app/src/main/res/values-nl/strings.xml # app/src/main/res/values-pl/strings.xml # app/src/main/res/values-pt/strings.xml # app/src/main/res/values-ro/strings.xml # app/src/main/res/values-ru/strings.xml # app/src/main/res/values-sk/strings.xml # app/src/main/res/values-sl/strings.xml # app/src/main/res/values-sv/strings.xml # app/src/main/res/values-tr/strings.xml # app/src/main/res/values/strings.xml
mikescamell
added a commit
that referenced
this pull request
Oct 21, 2024
Task/Issue URL: https://app.asana.com/0/1207908166761516/1208156273709078/f ### Description Adds the “Show on App Launch” entry point in the General settings screen. We will likely not use a `String` to determine the secondary text but this makes it easier for step by step implementation. [Designs](https://www.figma.com/design/N2GbF5HEvopp5iwmAlMwyD/New-Tab-Page-Customization?node-id=1741-64494&t=SpS14wACEtPydb2z-4) ### Steps to test this PR - [x] Open settings - [x] Click “General” - [x] Check “Show on App Launch” is bottom of the list ### UI changes | Before | After | | ------ | ----- | |  |  | --------- Co-authored-by: Marcos Holgado <marcosh@duckduckgo.com> Co-authored-by: Dax The Translator <daxmobile@duckduckgo.com> # Conflicts: # app/src/main/res/values-bg/strings.xml # app/src/main/res/values-cs/strings.xml # app/src/main/res/values-da/strings.xml # app/src/main/res/values-de/strings.xml # app/src/main/res/values-el/strings.xml # app/src/main/res/values-es/strings.xml # app/src/main/res/values-et/strings.xml # app/src/main/res/values-fi/strings.xml # app/src/main/res/values-fr/strings.xml # app/src/main/res/values-hr/strings.xml # app/src/main/res/values-hu/strings.xml # app/src/main/res/values-it/strings.xml # app/src/main/res/values-lt/strings.xml # app/src/main/res/values-lv/strings.xml # app/src/main/res/values-nb/strings.xml # app/src/main/res/values-nl/strings.xml # app/src/main/res/values-pl/strings.xml # app/src/main/res/values-pt/strings.xml # app/src/main/res/values-ro/strings.xml # app/src/main/res/values-ru/strings.xml # app/src/main/res/values-sk/strings.xml # app/src/main/res/values-sl/strings.xml # app/src/main/res/values-sv/strings.xml # app/src/main/res/values-tr/strings.xml # app/src/main/res/values/strings.xml
This was referenced Oct 21, 2024
mikescamell
added a commit
that referenced
this pull request
Oct 28, 2024
Task/Issue URL: https://app.asana.com/0/1207908166761516/1208156273709078/f Adds the “Show on App Launch” entry point in the General settings screen. We will likely not use a `String` to determine the secondary text but this makes it easier for step by step implementation. [Designs](https://www.figma.com/design/N2GbF5HEvopp5iwmAlMwyD/New-Tab-Page-Customization?node-id=1741-64494&t=SpS14wACEtPydb2z-4) - [x] Open settings - [x] Click “General” - [x] Check “Show on App Launch” is bottom of the list | Before | After | | ------ | ----- | |  |  | --------- Co-authored-by: Marcos Holgado <marcosh@duckduckgo.com> Co-authored-by: Dax The Translator <daxmobile@duckduckgo.com>
4 tasks
mikescamell
added a commit
that referenced
this pull request
Oct 30, 2024
Task/Issue URL: https://app.asana.com/0/1207908166761516/1208156273709078/f Adds the “Show on App Launch” entry point in the General settings screen. We will likely not use a `String` to determine the secondary text but this makes it easier for step by step implementation. [Designs](https://www.figma.com/design/N2GbF5HEvopp5iwmAlMwyD/New-Tab-Page-Customization?node-id=1741-64494&t=SpS14wACEtPydb2z-4) - [x] Open settings - [x] Click “General” - [x] Check “Show on App Launch” is bottom of the list | Before | After | | ------ | ----- | |  |  | --------- Co-authored-by: Marcos Holgado <marcosh@duckduckgo.com> Co-authored-by: Dax The Translator <daxmobile@duckduckgo.com>
mikescamell
added a commit
that referenced
this pull request
Nov 4, 2024
Task/Issue URL: https://app.asana.com/0/1207908166761516/1208156273709078/f Adds the “Show on App Launch” entry point in the General settings screen. We will likely not use a `String` to determine the secondary text but this makes it easier for step by step implementation. [Designs](https://www.figma.com/design/N2GbF5HEvopp5iwmAlMwyD/New-Tab-Page-Customization?node-id=1741-64494&t=SpS14wACEtPydb2z-4) - [x] Open settings - [x] Click “General” - [x] Check “Show on App Launch” is bottom of the list | Before | After | | ------ | ----- | |  |  | --------- Co-authored-by: Marcos Holgado <marcosh@duckduckgo.com> Co-authored-by: Dax The Translator <daxmobile@duckduckgo.com>
11 tasks
mikescamell
added a commit
that referenced
this pull request
Nov 6, 2024
Task/Issue URL: https://app.asana.com/0/1207908166761516/1208156273709078/f Adds the “Show on App Launch” entry point in the General settings screen. We will likely not use a `String` to determine the secondary text but this makes it easier for step by step implementation. [Designs](https://www.figma.com/design/N2GbF5HEvopp5iwmAlMwyD/New-Tab-Page-Customization?node-id=1741-64494&t=SpS14wACEtPydb2z-4) - [x] Open settings - [x] Click “General” - [x] Check “Show on App Launch” is bottom of the list | Before | After | | ------ | ----- | |  |  | --------- Co-authored-by: Marcos Holgado <marcosh@duckduckgo.com> Co-authored-by: Dax The Translator <daxmobile@duckduckgo.com>
6 tasks
mikescamell
added a commit
that referenced
this pull request
Nov 6, 2024
Task/Issue URL: https://app.asana.com/0/1207908166761516/1208156273709078/f Adds the “Show on App Launch” entry point in the General settings screen. We will likely not use a `String` to determine the secondary text but this makes it easier for step by step implementation. [Designs](https://www.figma.com/design/N2GbF5HEvopp5iwmAlMwyD/New-Tab-Page-Customization?node-id=1741-64494&t=SpS14wACEtPydb2z-4) - [x] Open settings - [x] Click “General” - [x] Check “Show on App Launch” is bottom of the list | Before | After | | ------ | ----- | |  |  | --------- Co-authored-by: Marcos Holgado <marcosh@duckduckgo.com> Co-authored-by: Dax The Translator <daxmobile@duckduckgo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207908166761516/1208156273709078/f
Description
Adds the “Show on App Launch” entry point in the General settings screen.
We will likely not use a
Stringto determine the secondary text but this makes it easier for step by step implementation.Designs
Steps to test this PR
UI changes