Separate disabled state from non-editable state for DaxTextInput

[CDRussell]

Task/Issue URL: https://app.asana.com/0/488551667048375/1208740714999313/f

Description

Separates non-editable state from disabled state of DaxTextInput. An input can be:

• non-editable but enabled (i.e., read-only text that isn't greyed out, with buttons in the view still working)
• disabled (i.e., non-editable and greyed out, and all buttons disabled too)

Steps to test this PR

Passwords

• Go to Passwords and tap ➕ to manually start adding a password
• Verify the input fields behave correctly
• Save the password; verify the fields correctly go to read-only mode (non-editable state), and that the buttons on the fields work (like copy password, reveal password etc...)
• Edit the password again and verify the fields correctly go to editable state

App launch setting

• Go to Settings -> General -> Show on App Launch
• Verify the URL is greyed out and non-editable when it is not selected
• Select it, and verify the URL is no longer greyed out, and is now editable
• Unselect it again and make sure that works correctly

Anything else that might be affected?

[CDRussell]

• Separate disabled state from non-editable state for DaxTextInput #5265 👈
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CDRussell and the rest of your teammates on Graphite

[CDRussell]

isEnabled implies non-editability, plus you also get the disabled look

[malmstein]

If we want to use the disabled state, it should also work when the value is set in the XML directly. At the moment it only works if the value is set explicitly by code.

[malmstein]

I’ve added the attribute so it can read from inflation. Rest looks good!

[CDRussell]

I’ve added the attribute so it can read from inflation. Rest looks good!

Awesome, thanks @malmstein