Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move out of main cta viewmodel checks #5414

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

cmonfortep
Copy link
Contributor

@cmonfortep cmonfortep commented Dec 19, 2024

Task/Issue URL: https://app.asana.com/0/1202552961248957/1208737359937198/f

Description

Moves to io main threads db access detected in CtaViewmodel

Steps to test this PR

Feature 1

  • Smoke tests onboarding
  • [ ]

UI changes

Before After
!(Upload before screenshot) (Upload after screenshot)

@cmonfortep
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cmonfortep cmonfortep requested a review from nalcalag December 19, 2024 13:25
@nalcalag nalcalag self-assigned this Dec 19, 2024
Copy link
Contributor

@nalcalag nalcalag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cmonfortep cmonfortep merged commit 381fdc9 into develop Dec 20, 2024
7 checks passed
@cmonfortep cmonfortep deleted the feature/cristian/ensure_cta_checks_in_io branch December 20, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants