Logging tweaks

duckduckgo · Nov 23, 2023 · 5a57d06 · 5a57d06
1 parent 7c84dec
commit 5a57d06
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/lib/cmps/base.ts b/lib/cmps/base.ts
@@ -63,7 +63,7 @@ export default class AutoConsentCMPBase implements AutoCMP {
     }
 
     const snippetSrc = getFunctionBody(snippet);
-    enableLogs && console.log('async eval:', snippetId, snippetSrc);
+    // enableLogs && console.log('async eval:', snippetId, snippetSrc);
     return requestEval(snippetSrc).catch((e) => {
       enableLogs && console.error('error evaluating rule', snippetId, e);
       return false;

diff --git a/lib/config.ts b/lib/config.ts
@@ -1 +1,2 @@
+// TODO: make this configurable through DevTools (and possibly toggleable per rule step type)
 export const enableLogs = false; // change this to enable debug logs
diff --git a/lib/rule-executors.ts b/lib/rule-executors.ts
@@ -43,7 +43,7 @@ export function elementVisible(selector: ElementSelector, check: VisibilityCheck
 export function waitForElement(selector: ElementSelector, timeout = 10000): Promise<boolean> {
   const interval = 200;
   const times = Math.ceil((timeout) / interval);
-  // enableLogs && console.log("[waitFor]", ruleStep.waitFor);
+  enableLogs && console.log("[waitForElement]", selector);
   return waitFor(
     () => elementSelector(selector).length > 0,
     times,

diff --git a/lib/web.ts b/lib/web.ts
@@ -110,7 +110,7 @@ export default class AutoConsent {
     declarativeRules.autoconsent.forEach((ruleset) => {
       this.addDeclarativeCMP(ruleset);
     });
-    enableLogs && console.log("added rules", this.rules);
+    // enableLogs && console.log("added rules", this.rules);
   }
 
   addDeclarativeCMP(ruleset: AutoConsentCMPRule) {
@@ -397,7 +397,7 @@ export default class AutoConsent {
   }
 
   async receiveMessageCallback(message: BackgroundMessage) {
-    if (enableLogs && ['evalResp', 'report'].includes(message.type) /* evals are noisy */) {
+    if (enableLogs && !['evalResp', 'report'].includes(message.type) /* evals are noisy */) {
       console.log('received from background', message, window.location.href);
     }
     switch (message.type) {
Original file line number	Diff line number	Diff line change
		@@ -1 +1,2 @@
		// TODO: make this configurable through DevTools (and possibly toggleable per rule step type)
		export const enableLogs = false; // change this to enable debug logs