Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCPA fix for Sourcepoint #302

Merged
merged 4 commits into from
Nov 27, 2023
Merged

CCPA fix for Sourcepoint #302

merged 4 commits into from
Nov 27, 2023

Conversation

muodov
Copy link
Member

@muodov muodov commented Nov 23, 2023

https://app.asana.com/0/1201844467387842/1206018883047114/f


@muodov muodov requested a review from sammacbeth November 23, 2023 15:57
@muodov muodov added patch Increment the patch version when merged release Create a release when this pr is merged labels Nov 23, 2023
Copy link
Collaborator

@sammacbeth sammacbeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Worked for me in local testing. Can you just tidy up the log statements before merging?

lib/cmps/base.ts Outdated
enableLogs && console.log('async eval:', snippetId, snippetSrc);
// enableLogs && console.log('async eval:', snippetId, snippetSrc);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't want the logging, should we just remove this line?

lib/web.ts Outdated Show resolved Hide resolved
@muodov muodov merged commit 58a1a5a into main Nov 27, 2023
5 checks passed
@muodov muodov deleted the ccpa-sourcepoint-fix branch November 27, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants