Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential memory leak in BloomFilterWrapper #806

Closed
s3cur3 opened this issue Jan 13, 2021 · 3 comments
Closed

Potential memory leak in BloomFilterWrapper #806

s3cur3 opened this issue Jan 13, 2021 · 3 comments

Comments

@s3cur3
Copy link
Contributor

s3cur3 commented Jan 13, 2021

The BloomFilterWrapper doesn't clean up the BloomFilter it allocates on init. As best I can tell, this is mostly a theoretical leak—in the app, the BloomFilterWrapper is currently retained for the lifetime of the program. If this ever were not the case though (as is the case in the test suite), the allocated BloomFilter would be leaked.

If you'd like, I can submit a pull request for the (tiny) fix.

@brindy
Copy link
Contributor

brindy commented Feb 13, 2021

Sorry for the delay in replying. Yes, feel free to submit a PR. As you say the filter is tied to the the lifetime of the app anyway so no rush. Thanks!

@brindy
Copy link
Contributor

brindy commented Feb 13, 2021

Tracking internally here: https://app.asana.com/0/392891325557410/1199935106721785

@samsymons
Copy link
Contributor

Closing this as #833 was merged, thanks @s3cur3!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants