You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The BloomFilterWrapper doesn't clean up the BloomFilter it allocates on init. As best I can tell, this is mostly a theoretical leak—in the app, the BloomFilterWrapper is currently retained for the lifetime of the program. If this ever were not the case though (as is the case in the test suite), the allocated BloomFilter would be leaked.
If you'd like, I can submit a pull request for the (tiny) fix.
The text was updated successfully, but these errors were encountered:
Sorry for the delay in replying. Yes, feel free to submit a PR. As you say the filter is tied to the the lifetime of the app anyway so no rush. Thanks!
The
BloomFilterWrapper
doesn't clean up theBloomFilter
it allocates on init. As best I can tell, this is mostly a theoretical leak—in the app, theBloomFilterWrapper
is currently retained for the lifetime of the program. If this ever were not the case though (as is the case in the test suite), the allocatedBloomFilter
would be leaked.If you'd like, I can submit a pull request for the (tiny) fix.
The text was updated successfully, but these errors were encountered: