Fix potential memory leak in BloomFilterWrapper #833
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As best I can tell, this is mostly theoretical
at this point---the BloomFilterWrapper is currently
retained for the lifetime of the program. If this
ever were not the case, though, we'd be leaking
the allocated BloomFilter object without a
delete
corresponding to its
new
.Steps to test this PR:
You can observe the leak in the test suite, which
does create temporary
BloomFilterWrapper
s: justadd a destructor to BloomFilter.hpp in the submodule
like this:
...and observe that it's never called without this
patch, and consistently called with it.
Issue URL: #806
Internal URL: https://app.asana.com/0/392891325557410/1199935106721785