Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.cfg: Relax version constraints on all dependencies #244

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Conversation

nbraud
Copy link
Collaborator

@nbraud nbraud commented Apr 10, 2021

Pinning exact versions makes software that share dependencies essentially-impossible to install in the same environment. See #243 for an example of this kind of issue.

We use the “compatible version” operator, ~=, to specify version constraints, essentially assuming that our dependencies follow SemVer.

@nbraud
Copy link
Collaborator Author

nbraud commented Apr 10, 2021

There will be a merge conflict with #243, which should be merged first (this PR is less complex and easier to fix up)

@nbraud nbraud mentioned this pull request Apr 11, 2021
3 tasks
@duckinator
Copy link
Owner

@nbraud this PR also looks good. 👍

Pinning exact versions makes software that share dependencies
essentially-impossible to install in the same environment. See #243.

We use the “compatible version” operator, `~=`, to specify version constraints,
essentially assuming that our dependencies follow SemVer.
@nbraud
Copy link
Collaborator Author

nbraud commented Apr 20, 2021

bors r=duckinator

@bors
Copy link
Contributor

bors bot commented Apr 20, 2021

Build succeeded:

@bors bors bot merged commit e2f04f0 into master Apr 20, 2021
@bors bors bot deleted the unpin-deps branch April 20, 2021 23:10
bors bot added a commit that referenced this pull request Apr 21, 2021
247: Configure PyUp to deal with unpinned deps (and minor nitpick) r=nbraud a=nbraud

See #244, #246.

Co-authored-by: nicoo <nicoo@mur.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants