This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64
If an event is fired from within a component with shadow DOM and listened to outside (like document or window), the
event.target
will not pierce the shadow DOM and show as the top level component. For example, listening to a click event on the document in the following situation (iffoo-bar
had a shadow dom)will have
foo-bar
as the event target! Therefore the conditionif (this.dialogWrapperNode.contains(target) || this.datePickerButton.contains(target)) {
will not be met because target always returns a parent node!Enter
composedPath
to the rescue. https://developer.mozilla.org/en-US/docs/Web/API/Event/composedPathIt returns an array of nodes and will contain shadow dom nodes as long as it is
open
.I realized that
composedPath
is not supported in IE (IE doesn't support shadow dom at all), so ifcomposedPath
is available it will be used, otherwise it will fallback to target.