Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove weird/unused options from WM configuration #160

Closed
dummylabs opened this issue Nov 21, 2024 · 1 comment
Closed

Remove weird/unused options from WM configuration #160

dummylabs opened this issue Nov 21, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@dummylabs
Copy link
Owner

The following options will be removed from WM configuration dialog:

  • notification action name
  • notification action data
  • notification message chunk size

Motivation: The logic behind them is somewhat cumbersome. Users may set and forget these action call parameters in the configuration, and they may interfere with the action call input data. Of course, they remain available as action parameters.

The following parameter will be removed from action input parameters:

  • send_notification

Motivation: it becomes redundant since action parameter must be set anyway to invoke a notification action. It is still accepted by watchman.report action in 0.6.4 and will be deprecated/removed later.

@dummylabs dummylabs added the enhancement New feature or request label Nov 21, 2024
@dummylabs
Copy link
Owner Author

Implemented in 0.6.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant