Feature: Download CSV #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bh2smith
force-pushed
the
split-client-class
branch
from
b84dd2c to
f3e948a
Compare
bh2smith
force-pushed
the
download-csv
branch
2 times, most recently
from
94d0546 to
b2204fa
Compare
bh2smith
force-pushed
the
split-client-class
branch
from
46959b7 to
1eed668
Compare
bh2smith
force-pushed
the
download-csv
branch
from
32d253d to
7edc25a
Compare
bh2smith
force-pushed
the
split-client-class
branch
from
1eed668 to
abdc08b
Compare
bh2smith
force-pushed
the
download-csv
branch
2 times, most recently
from
fde63d9 to
f1fec83
Compare
diegoximenes
reviewed
Sep 7, 2023
bh2smith
commented
Sep 7, 2023
| url = self._route_url(f"/execution/{job_id}/results/csv") | ||
| self.logger.debug(f"GET CSV received input url={url}") | ||
| response = self._get(route=route, raw=True) |
There was a problem hiding this comment.
This was unnecessary because the _get method does this same debug logging.
Comment on lines
-107
to
+84
| https://dune.com/docs/api/api-reference/latest_results/ | ||
| https://dune.com/docs/api/api-reference/get-results/latest-results |
There was a problem hiding this comment.
URL has changed since last time.
| pandas.from_csv(data) | ||
| pandas.read_csv(data) |
bh2smith
force-pushed
the
split-client-class
branch
from
4567baa to
2aa3ad0
Compare
bh2smith
force-pushed
the
download-csv
branch
from
9f41015 to
37ff8ed
Compare
bh2smith
commented
Sep 8, 2023
bh2smith
force-pushed
the
download-csv
branch
from
421211e to
90187a1
Compare
bh2smith
added a commit
that referenced
this pull request
Sep 8, 2023
* only run e2e on one python version (fewer requests) * add download_csv functionality (#73)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is similar to that of
get_latest_resultsexcept that it returns in CSV format as outlined here: https://dune.com/docs/api/api-reference/get-results/latest-results/I noticed that the docs don't give example responses of the csv route.
A few things were updated here (url to api docs on
get_latest_results).We created a utility function to avoid tripling the same code block that handles query objects or types. Functionality is now unit tested.
Closes #66
cc @TheEdgeOfRage & @diegoximenes for additional review.