-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nft linked addresses #1457
Add nft linked addresses #1457
Conversation
@springzh it appears solana has some missing data compared to other blockchains in the buyer/seller fields. there are "dupes" based on null values:
|
following up on this. since there are dupes, the merge could fail in theory. are you looking into how the data contains nulls for addresses on solana / potential changes to fix it? |
Workflow run id 3004850208 approved. |
Workflow run id 3004862785 approved. |
Workflow run id 3004993798 approved. |
Sorry for the delay. I updated it to ignore records that contain null buyer and seller values. Manually tested by copying the generated sql: |
fyi @soispoke for deployment(s) -- i tested locally and built fresh, ran incremental, ensured no dupes, built seed and ran tests. all seem to be fine to me |
the beta ci test failed because we use '+' in front of the |
@jeff-dude I think more work is needed on that front, I added the + in the dbt command otherwise it was trying to build new models without building dependencies first, but yes it turns out most additions are too heavy and time out. |
Brief comments on the purpose of your changes:
Added nft.linked_addresses to track all linked user addresses that buy and sell NFTs to each other, back and forth.
For Dune Engine V2
I've checked that:
lowercase_snake_cased
When you are ready for a review, tag duneanalytics/data-experience. We will re-open your forked pull request as an internal pull request. Then your spells will run in dbt and the logs will be avaiable in Github Actions DBT Slim CI. This job will only run the models and tests changed by your PR compared to the production project.