-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ringers Metadata Spell #1493
Conversation
Workflow run id 2981822738 approved. |
Hi @catherine-2 thanks for your submission ! Can you please adapt the |
Workflow run id 2994365976 approved. |
Thank you @soispoke ! I just updated the format to match that example |
@catherine-2 thanks for applying changes, would you like to expose this view on Dune.com as well ? Here is the macro where you need to add your new model: After this lgtm! |
Thank you @soispoke - yeah I can add that. To make sure I understand - when you say 'expose this view on dune.com' does that mean in the online documentation, in the table list in the query editor, or both? |
@catherine-2 Good question, "exposing a table" means showing it the query editor, or data explorer. You don't need to add it in the macro to have it show up in the online documentation, this is done automatically |
@soispoke Got it! In that case if it will work could we merge this and I will expose it in the query editor in a future pull request? This first PR was mostly to make sure I could figure out how to get dbt working and make the pull request :) I will submit another PR this week or next that has several other metadata tables in it. Probably makes sense to expose the "metadata" folder in the query editor once there are more tables populated? Or we can keep this open until I have those ready and I can edit the name and add them all to this - whatever you prefer! |
@catherine-2 It's really your call, if you rather want to wait a bit before showing this on Dune.com in the explorer it's completely fine and we can merge now 👍 |
@soispoke awesome let's merge now then to remove from the queue and I will make a note to expose this table alongside the others once those are added thank you so much for your help! |
sounds good, thanks for submitting this first spell 🔥 @catherine-2 ! |
@soispoke is there a delay for the table to show up on the documentation page? I had set it up to have a folder called 'metadata' under the nft model category but am not seeing it. Want to make sure I didn't mess it up and if I did make sure I know how to fix it in the next PR! https://spellbook-docs.dune.com/#!/model/model.spellbook.nft_ethereum_aggregators |
@catherine-2 yes there is, the best way to make sure everything worked is just to query your table on Dune :) |
@soispoke ah got it - was typing the name in wrong trying to check it :) thank you for opening the other PR to fix! |
Brief comments on the purpose of your changes:
Hi! This is my first spell PR so using a basic query first that is all static data :)
Please let me know if I missed any files or information needed
One thing to note: I created a new subfolder under nft_ethereum called "metadata" to store metadata tables for NFT collections. I think these would be useful to have as spells (I have a number of user generated metadata tables I can upload so others can use them too). Let me know if there is a different way you'd like to organize these tables.
For Dune Engine V2
I've checked that:
General checks:
lowercase_snake_cased
Join logic:
Incremental logic: