Add static cex labels #1512

soispoke · 2022-09-06T06:26:48Z

This PR is meant to give an example of static labels added to the spellbook repo for CEX on ethereum.

Brief comments on the purpose of your changes:

For Dune Engine V2
I've checked that:
General checks:

I tested the query on dune.com after compiling the model with dbt compile (compiled queries are written to the target directory)
I used "refs" to reference other models in this repo and "sources" to reference raw or decoded tables
if adding a new model, I added a test
the filename is unique and ends with .sql
each sql file is a select statement and has only one view, table or function defined
column names are lowercase_snake_cased
if adding a new model, I edited the dbt project YAML file with new directory path for both models and seeds (if applicable)
if adding a new model, I edited the alter table macro to display new database object (table or view) in UI explorer
if adding a new materialized table, I edited the optimize table macro

Join logic:

if joining to base table (i.e. ethereum transactions or traces), I looked to make it an inner join if possible

Incremental logic:

I used is_incremental & not is_incremental jinja block filters on both base tables and decoded tables
- where block_time >= date_trunc("day", now() - interval '1 week')
if joining to base table (i.e. ethereum transactions or traces), I applied join condition where block_time >= date_trunc("day", now() - interval '1 week')
if joining to prices view, I applied join condition where minute >= date_trunc("day", now() - interval '1 week')

aalan3 · 2022-09-06T18:22:25Z

models/labels/cex/labels_cex_ethereum.sql

+SELECT blockchain, address, name, category, contributor, source, created_at, updated_at
+FROM (VALUES
+    -- Binance, Source: https://etherscan.io/accounts/label/binance
+    (array('ethereum'),'0x3f5ce5fbfe3e9af3971dd833d26ba9b5c936f0be', 'Binance 1', 'cex', 'hildobby', 'static', timestamp('2022-08-28'), now())


shouldn't updated_at be the same as created_at

i could see it either way, but if they're the same, then we should just have updated_at only and leave out created_at

The idea here is to have created_at reflect the moment at which contributors create the query/static labels for the first time, while updated_at reflects the last date at which the table was updated/rebuilt

jeff-dude · 2022-09-06T20:38:01Z

dbt_project.yml

+
+    labels:
+      +schema: labels
+      +materialized: view


if you leave out the subdirectories (i.e. ethereum) here, will all schemas in the 'labels' directory default to 'labels'?

jeff-dude · 2022-09-06T20:44:00Z

models/labels/cex/labels_cex_ethereum.sql

+SELECT blockchain, address, name, category, contributor, source, created_at, updated_at
+FROM (VALUES
+    -- Binance, Source: https://etherscan.io/accounts/label/binance
+    (array('ethereum'),'0x3f5ce5fbfe3e9af3971dd833d26ba9b5c936f0be', 'Binance 1', 'cex', 'hildobby', 'static', timestamp('2022-08-28'), now())


i could see it either way, but if they're the same, then we should just have updated_at only and leave out created_at

jeff-dude · 2022-09-06T20:45:03Z

models/labels/cex/labels_cex_ethereum.sql

+SELECT blockchain, address, name, category, contributor, source, created_at, updated_at
+FROM (VALUES
+    -- Binance, Source: https://etherscan.io/accounts/label/binance
+    (array('ethereum'),'0x3f5ce5fbfe3e9af3971dd833d26ba9b5c936f0be', 'Binance 1', 'cex', 'hildobby', 'static', timestamp('2022-08-28'), now())


if this model is specific to ethereum, do we need to allow an array value for blockchain since it'll always be ethereum to match the model?

just noticed #1513 which i think clarifies my question here. while this PR may not use it, others will in the other PR, then later combined into one object

Yes exactly, for some more examples you can look at #1474 as well :)

jeff-dude · 2022-09-06T20:46:45Z

models/labels/labels_all.sql

+}}
+
+-- Static Labels
+SELECT * FROM {{ ref('labels_cex') }}


what are the future use cases of adding labels here, will they have the same columns and be able to just select * union?

i think #1513 may answer this as well, looks like you'll always conform to that standard

yes, that's also right 👍

soispoke

Yes that's right 👍

soispoke · 2022-09-07T04:16:14Z

models/labels/cex/labels_cex_ethereum.sql

+SELECT blockchain, address, name, category, contributor, source, created_at, updated_at
+FROM (VALUES
+    -- Binance, Source: https://etherscan.io/accounts/label/binance
+    (array('ethereum'),'0x3f5ce5fbfe3e9af3971dd833d26ba9b5c936f0be', 'Binance 1', 'cex', 'hildobby', 'static', timestamp('2022-08-28'), now())


The idea here is to have created_at reflect the moment at which contributors create the query/static labels for the first time, while updated_at reflects the last date at which the table was updated/rebuilt

soispoke · 2022-09-07T04:19:18Z

models/labels/cex/labels_cex_ethereum.sql

+SELECT blockchain, address, name, category, contributor, source, created_at, updated_at
+FROM (VALUES
+    -- Binance, Source: https://etherscan.io/accounts/label/binance
+    (array('ethereum'),'0x3f5ce5fbfe3e9af3971dd833d26ba9b5c936f0be', 'Binance 1', 'cex', 'hildobby', 'static', timestamp('2022-08-28'), now())


Yes exactly, for some more examples you can look at #1474 as well :)

soispoke · 2022-09-07T04:19:48Z

models/labels/labels_all.sql

+}}
+
+-- Static Labels
+SELECT * FROM {{ ref('labels_cex') }}


yes, that's also right 👍

soispoke

thanks @aalan3 and @jeff-dude for taking the time to review this

jeff-dude

i think i'm good with this 👍

soispoke · 2022-09-08T07:02:54Z

thanks @jeff-dude !

soispoke added 2 commits September 6, 2022 08:22

add static cex labels

698d7ef

Update dbt_project.yml

02ee110

soispoke requested review from aalan3 and masquot September 6, 2022 06:26

aalan3 reviewed Sep 6, 2022

View reviewed changes

jeff-dude added the v2_engine label Sep 6, 2022

jeff-dude reviewed Sep 6, 2022

View reviewed changes

soispoke commented Sep 7, 2022

View reviewed changes

soispoke requested review from jeff-dude and aalan3 September 7, 2022 04:26

jeff-dude approved these changes Sep 7, 2022

View reviewed changes

soispoke merged commit 25b44cd into main Sep 8, 2022

jeff-dude deleted the Add-static-CEX-labels- branch September 8, 2022 14:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add static cex labels #1512

Add static cex labels #1512

soispoke commented Sep 6, 2022 •

edited

Loading

aalan3 Sep 6, 2022

jeff-dude Sep 6, 2022

soispoke Sep 7, 2022

jeff-dude Sep 6, 2022

jeff-dude Sep 6, 2022

jeff-dude Sep 6, 2022

jeff-dude Sep 6, 2022

soispoke Sep 7, 2022 •

edited

Loading

jeff-dude Sep 6, 2022

jeff-dude Sep 6, 2022

soispoke Sep 7, 2022

soispoke left a comment

soispoke Sep 7, 2022

soispoke Sep 7, 2022 •

edited

Loading

soispoke Sep 7, 2022

soispoke left a comment

jeff-dude left a comment

soispoke commented Sep 8, 2022

Add static cex labels #1512

Add static cex labels #1512

Conversation

soispoke commented Sep 6, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

soispoke Sep 7, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

soispoke left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

soispoke Sep 7, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

soispoke left a comment

Choose a reason for hiding this comment

jeff-dude left a comment

Choose a reason for hiding this comment

soispoke commented Sep 8, 2022

soispoke commented Sep 6, 2022 •

edited

Loading

soispoke Sep 7, 2022 •

edited

Loading

soispoke Sep 7, 2022 •

edited

Loading