-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gnosis safe airdrop address data #1535
Conversation
Workflow run id 3016747036 approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Workflow run id 3020564966 approved. |
macros/alter_table_properties.sql
Outdated
'dune.data_explorer.blockchains'='["ethereum"]', | ||
'dune.data_explorer.category'='abstraction', | ||
'dune.data_explorer.abstraction.type'='sector', | ||
'dune.data_explorer.abstraction.name'='safe_airdrop', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about this line. What's the usage for the abstraction name? Should it be always set to same as table name?
macros/alter_table_properties.sql
Outdated
'dune.data_explorer.blockchains'='["ethereum"]', | ||
'dune.data_explorer.category'='abstraction', | ||
'dune.data_explorer.abstraction.type'='sector', | ||
'dune.data_explorer.abstraction.name'='safe_airdrop', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, I think the type should be sector
, and the name addresses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
The model file name should be addresses_ethereum_safe_airdrop.sql instead of safe_airdrop.sql |
Workflow run id 3026550899 approved. |
@soispoke Renamed. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm !
Brief comments on the purpose of your changes:
Added value based data table for gnosis safe airdrop data. Source file downloaded from https://raw.githubusercontent.com/safe-global/safe-user-allocation-reports/main/safe_user_allocations_reworked.csv
For Dune Engine V2
I've checked that:
General checks:
lowercase_snake_cased
Join logic:
Incremental logic: