Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daily spellbook sub project #6027

Merged
merged 43 commits into from
May 30, 2024
Merged

Daily spellbook sub project #6027

merged 43 commits into from
May 30, 2024

Conversation

aalan3
Copy link
Contributor

@aalan3 aalan3 commented May 29, 2024

This PR initiates the a new sub project for models that are going to be run daily.

I also added the necessary CI steps,and (generated and) uploaded a manifest to S3 so that CI works.

@aalan3 aalan3 requested review from couralex6, 0xRobin and jeff-dude May 29, 2024 13:19
Comment on lines 4 to 7
- package: dbt-labs/codegen
version: 0.12.1
- package: starburstdata/trino_utils
version: 0.6.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are new? Should we also add them to the main packages.yml?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes probably, @jeff-dude added these files but we can update main in a separate PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these were added during @couralex6 discovery of subprojects during tokens build. i believe codegen was intended to help the process of moving files around, but not actively used? then trino_utils is just trino-specific dbt_utils. we can just add per subproject as needed. as of now, i'm not sure we actually use any from there

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe i'll remove from this new subproject, to ensure it doesn't break anything without

Base automatically changed from ci-shared-workflows to main May 29, 2024 15:13
Comment on lines +72 to +91
chainlink:
+schema: chainlink
arbitrum:
+schema: chainlink_arbitrum
avalanche_c:
+schema: chainlink_avalanche_c
base:
+schema: chainlink_base
bnb:
+schema: chainlink_bnb
ethereum:
+schema: chainlink_ethereum
fantom:
+schema: chainlink_fantom
gnosis:
+schema: chainlink_gnosis
optimism:
+schema: chainlink_optimism
polygon:
+schema: chainlink_polygon
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just noting that we will want to remove these soon and put in models. just a lot of models to do. we can wait until the team refactors the code into macros (already underway)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah agree, was surprised to see these in the project file

@jeff-dude
Copy link
Member

i'm going to push a commit to try to remove those extra packages for now, to prove they aren't needed. we're also in a tough spot here, where CI won't run because the changes to CI are in the same PR.

@jeff-dude
Copy link
Member

i'm going to push a commit to try to remove those extra packages for now, to prove they aren't needed. we're also in a tough spot here, where CI won't run because the changes to CI are in the same PR.

actually, looks like the workflow does run, but no models kicked off?

@jeff-dude jeff-dude added WIP work in progress in review Assignee is currently reviewing the PR dune team created by dune team labels May 29, 2024
@jeff-dude jeff-dude self-assigned this May 29, 2024
@jeff-dude
Copy link
Member

mentioned in DMs with alan, but we should double check the downstream impacts of moving these. for instance, what else in spellbook reads from any of these as a ref()

@aalan3
Copy link
Contributor Author

aalan3 commented May 30, 2024

actually, looks like the workflow does run, but no models kicked off?

This is because I ran the compile locally and uploaded the manifest. Once merged it will automatically do a full refresh in DBT cloud.

@aalan3 aalan3 merged commit 6005396 into main May 30, 2024
4 checks passed
@aalan3 aalan3 deleted the daily-spellbook branch May 30, 2024 08:42
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dune team created by dune team in review Assignee is currently reviewing the PR WIP work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants