Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move nft tokens metadata to tokens subproject #6034

Merged
merged 17 commits into from
May 31, 2024
Merged

Move nft tokens metadata to tokens subproject #6034

merged 17 commits into from
May 31, 2024

Conversation

aalan3
Copy link
Contributor

@aalan3 aalan3 commented May 30, 2024

This PR moves the existing tokens.nft lineage to the tokens subproject. Solana tokens are not moved for now. This is in preparation for moving the contract mappings lineage

@aalan3 aalan3 requested review from couralex6, jeff-dude and 0xRobin May 30, 2024 10:40
@@ -103,7 +103,7 @@ SELECT
ELSE coalesce(agg_mark.aggregator_name, agg1.name, agg2.name)
END as aggregator_name
FROM {{base_trades}} base
LEFT JOIN {{ref('tokens_nft')}} nft
LEFT JOIN {{source('tokens', 'nft')}} nft
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi @0xRobin
we are looking to move nft token metadata to tokens subproject, similar to erc20, flipping to source is part of that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this one may be backwards?
all of these edition metadata spells should be moved to tokens subproject as they are dependencies for tokens_nft lineage. otherwise we create circular dependencies?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dbt ls --resource-type model --output name --select decent_optimism_edition_metadata+1
dbt ls --resource-type model --output name --select +decent_optimism_edition_metadata

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing upstream, only token metadata downstream

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah you are right I can move this to the tokens subproject

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be deleted?

@aalan3 aalan3 requested a review from jeff-dude May 30, 2024 17:41
Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running with modified turned off in prod for both projects

@jeff-dude jeff-dude merged commit f62a25b into main May 31, 2024
2 of 3 checks passed
@jeff-dude jeff-dude deleted the tokens-nft branch May 31, 2024 15:13
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants