Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We rename a previously internal method
_runInner
torefreshResults
which executes and loops until execution is complete (but does not fetch results). Additionally, we Introduce a new classPaginator
which fetches and caches and index result sets by page. This class exposes an api similar to the Dune interface result page navigation:Paginator can be constructed from the return value of
refreshResults
and a client of typeExecutionAPI
.Will want to add docs on how to use this, but the test introduced should give a pretty good idea of how to test it out in a front end.
Note that
the first commit (00ac359) is unrelated (fixing e2e test based on Dune's internal data format changes and expired query results).
the second commit (774b789) is just renaming an existing function and making it public (in preparation for public use)
🔑 the third commit (69c3088) This is the most relevant and substantial change introduced here: Paginator 📃
cc @agaperste.