Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate "/me" routes to API Platform #14

Merged
merged 1 commit into from
May 9, 2019
Merged

Migrate "/me" routes to API Platform #14

merged 1 commit into from
May 9, 2019

Conversation

teohhanhui
Copy link
Contributor

@teohhanhui teohhanhui commented Apr 29, 2019

@teohhanhui teohhanhui changed the title [WIP] Migrate "/me" routes to API Platform Migrate "/me" routes to API Platform Apr 30, 2019
Copy link
Collaborator

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I've seen:
image I was super happy. But then I noticed, that most of the added lines are due to test changes <3

'CONTENT_TYPE' => 'application/json',
'ACCEPT' => 'application/json',
], $updateData);

$response = $this->client->getResponse();
$this->assertResponse($response, 'customer/update_customer', Response::HTTP_OK);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we receive:

{"type":"https:\/\/tools.ietf.org\/html\/rfc2616#section-10","title":"An error occurred","detail":"No item route associated with the type \u0022Sylius\\Component\\Core\\Model\\Customer\u0022."}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's broken for now.

Needs api-platform/core#2714

@teohhanhui teohhanhui merged commit 951cb04 into dunglas:feat/gradually-migrate-to-api-platform May 9, 2019
@lchrusciel lchrusciel deleted the feat/gradually-migrate-to-api-platform branch May 9, 2019 14:25
@lchrusciel lchrusciel restored the feat/gradually-migrate-to-api-platform branch May 9, 2019 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants