Skip to content

Commit

Permalink
Addressing Liam's comments from paritytech#2657 (paritytech#3150)
Browse files Browse the repository at this point in the history
  • Loading branch information
bkontur authored Jan 31, 2024
1 parent 5a7532a commit 00e60b1
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ pub(crate) fn expand_variant_count(
// This is used for pallets without instance support or pallets with instance support when
// we don't specify instance:
//
// ```nocompile
// ```
// pub struct Pallet<T, I = ()>{..}
//
// #[pallet::composite_enum]
Expand Down
2 changes: 1 addition & 1 deletion substrate/frame/support/procedural/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1513,7 +1513,7 @@ pub fn origin(_: TokenStream, _: TokenStream) -> TokenStream {
///
/// ```ignore
/// Copy, Clone, Eq, PartialEq, Ord, PartialOrd, Encode, Decode, MaxEncodedLen, TypeInfo,
/// RuntimeDebug,
/// RuntimeDebug
/// ```
///
/// For ease of usage, when no `#[derive]` attributes are found for the enum under
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
use crate::pallet::Def;
use proc_macro2::TokenStream;

/// Expands `composite_enum` and adds the `VariantCount` implementation for it."
/// Expands `composite_enum` and adds the `VariantCount` implementation for it.
pub fn expand_composites(def: &mut Def) -> TokenStream {
let mut expand = quote::quote!();
let frame_support = &def.frame_support;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,14 +91,12 @@ pub struct CompositeDef {
pub index: usize,
/// The composite keyword used (contains span).
pub composite_keyword: keyword::CompositeKeyword,

/// Name of the associated type.
pub ident: syn::Ident,
/// Type parameters and where clause attached to a declaration of the pallet::composite_enum.
pub generics: syn::Generics,
/// The span of the pallet::composite_enum attribute.
pub attr_span: proc_macro2::Span,

/// Variant count of the pallet::composite_enum.
pub variant_count: u32,
}
Expand Down

0 comments on commit 00e60b1

Please sign in to comment.